refactor: consolidate tooling, pipeline blueprint, and asset alignment#1
Open
refactor: consolidate tooling, pipeline blueprint, and asset alignment#1
Conversation
2e95d43 to
54aee8f
Compare
- Remove root ontology-management-base submodule (now via recursive init through sl-5-8-asset-tools) - Add Makefile as central command center (OMB pattern) - Space-separated subcommands: make asset zip - OS detection for cross-platform support (Windows + Unix) - Path aliases hiding deep submodule paths - Update .pre-commit-config.yaml to use make validate hook - Update release workflow to use make targets exclusively - Add .github/copilot-instructions.md - Update README.md with new setup/validation instructions Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
54aee8f to
3ad2d8b
Compare
…erhaul Major changes: - Replace uploadedFiles.json with input_manifest.json (envited-x JSON-LD) - Add make generate: end-to-end asset creation pipeline with staging, validation, QC checks, and zip output to generated/ - Add EVES submodule pinned to asset-preparation-input-manifest branch - Modernize release.yml: softprops/action-gh-release@v2 - Cross-platform Makefile: Python-based zip/clean, OS detection - Update sl-5-8-asset-tools to include input_manifest support, venv PATH fix for QC executables, and [qc-deps] extras - Add generated/.gitkeep (contents gitignored, folder tracked) - Complete README rewrite with pipeline documentation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
- Track generated/input/ as the canonical pipeline blueprint (LFS for .png, .pdf, .xodr binaries) - Add 9 3d_preview JSON files to input manifest for pass-through - Update .gitignore: only ignore generated/output/, allow input/ - Update Makefile: generate reuses existing blueprint, generate clean preserves input/ directory - Remove obsolete generated/.gitkeep Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Add virtualcitySYSTEMS/opendriveconverter (Java/Gradle) as a submodule under submodules/opendriveconverter to serve as reference for the planned Python re-implementation of the OpenDRIVE to GeoJSON converter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Ontology schemas and SHACL shapes are now bundled locally via the ontology-management-base submodule. Only Nominatim reverse geocoding still requires an internet connection. Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
d32170c to
fe0e4d4
Compare
The asset/ folder is replaced by the pipeline-generated output in generated/output/. Submodule pointers updated to latest feature branch commits. Removed opendriveconverter submodule. Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
- Update submodule pointer to ruff migration commit - Make validate gracefully skip when asset/ doesn't exist yet Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
sl-5-8-asset-tools: conditional OMB install for CI EVES: table alignment fix for eves-007 Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Includes wizard_caller rewrite, SPDX license fix, and SD Creation Wizard submodules. Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
…ct.toml - copilot-instructions.md: replace deleted asset/ folder references with generated/input/ and generated/output/ pipeline workflow - pyproject.toml: remove (only contained stale black/isort config, no Python files in root repo) Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
- manifest_reference.json → manifest.json in Makefile validate + zip targets - hdmap_instance.json → hdmap.json in Makefile validate + zip targets - Update copilot-instructions.md to match new naming Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
- Remove unused ASSET_DIR variable from Makefile - Remove dead staging logic from make generate (require pre-populated input/) - Update README.md: manifest_reference.json -> manifest.json, hdmap_instance.json -> hdmap.json throughout - Update submodule pointer to sl-5-8-asset-tools Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Instead of duplicating pip install commands for sl-5-8-asset-tools and ontology-management-base, delegate to the submodule's own make setup/install targets. Pass VENV and PYTHON as absolute paths so the submodule uses the root venv. This removes 3 duplicated install blocks and ensures the submodule's Makefile is the single source of truth for its own deps. Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
…t zip - Remove make asset zip (pipeline already creates asset.zip) - Deduplicate generate validate → delegates to make validate - Simplify validate: use file-redirect instead of subprocess.check_call - Simplify clean: use native shell commands instead of inline Python - Update release.yml to use make generate + pipeline-generated zip - Update copilot-instructions.md for new workflow Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
- Switch EVES submodule URL from SSH to HTTPS for CI compatibility - Validate target now loops over all asset directories in generated/output/ instead of only picking dirs[0] Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
Includes pipeline fixes, pathlib migration, examples modernization, and external asset reference support. Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full consolidation of the hd-map-asset-example repository: tooling, pipeline, generated asset structure, and submodule alignment.
Build System & Tooling
Makefileas central command center (setup,generate,validate,clean,help)pre-commithooks with SHACL/JSON-LD validation.flake8(no Python files in root repo)pyproject.tomlAsset Structure (EVES-003)
asset/directory (replaced by pipeline-generated output)generated/input/withinput_manifest.json(JSON-LD), LFS-tracked simulation data, media, docs, LICENSEgenerated/output/(gitignored)Submodules
submodules/(sl-5-8-asset-tools, EVES)ontology-management-baseroot pointer (nested inside sl-5-8)CI/CD
release.ymlto usemake setup && make generate && make validateDocumentation
README.mdwith setup/usage/structure docscopilot-instructions.mdDiff stats
Commits (20)